Ensure finite values passed to SpectralEmbedding#7280
Merged
rapids-bot[bot] merged 1 commit intorapidsai:branch-25.10from Sep 29, 2025
Merged
Conversation
The C++ implementation doesn't support non-finite values. Sometimes this results in a failure-to-converge error, sometimes this results in an illegal memory access (and downstream failures eventually leading to potential segfaults).
jcrist
added
bug
csadorf
reviewed
Sep 29, 2025
csadorf
approved these changes
Sep 29, 2025
Member
Author
|
/merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The C++ implementation doesn't support non-finite values. Sometimes this results in a failure-to-converge error, sometimes this results in an illegal memory access (and downstream failures eventually leading to potential segfaults).
I believe this to be the root cause of #7274 (if we see a failure, it's preceded by illegal memory accesses here). I've run things locally a bunch after this fix and haven't seen a failure, going to try it in CI.
Fixes #7274.