Enforce correct dependencies on cuVS#7261
Merged
rapids-bot[bot] merged 8 commits intorapidsai:branch-25.10from Sep 25, 2025
Merged
Enforce correct dependencies on cuVS#7261rapids-bot[bot] merged 8 commits intorapidsai:branch-25.10from
rapids-bot[bot] merged 8 commits intorapidsai:branch-25.10from
Conversation
KyleFromNVIDIA
approved these changes
Sep 23, 2025
…eanup-cuvs-dependency
quasiben
reviewed
Sep 24, 2025
| - cuda-version=12.9 | ||
| - cudf==25.10.*,>=0.0.0a0 | ||
| - cupy>=13.6.0 | ||
| - cuvs==25.10.*,>=0.0.0a0 |
Member
There was a problem hiding this comment.
If you remove this will setting up dev environments be impacted ?
Member
Author
There was a problem hiding this comment.
No, this is intentional. We have never had a dependency on cuvs python package, so this dependency was wrongly expressed. There should be no side-effects to removing this.
csadorf
approved these changes
Sep 24, 2025
Contributor
|
/merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR changes two things:
libcuvsfor wheel builds, as we clone and build from source to facilitate static linkcuvsfor all builds