Skip to content

Enforce correct dependencies on cuVS#7261

Merged
rapids-bot[bot] merged 8 commits intorapidsai:branch-25.10from
divyegala:cleanup-cuvs-dependency
Sep 25, 2025
Merged

Enforce correct dependencies on cuVS#7261
rapids-bot[bot] merged 8 commits intorapidsai:branch-25.10from
divyegala:cleanup-cuvs-dependency

Conversation

@divyegala
Copy link
Copy Markdown
Member

@divyegala divyegala commented Sep 23, 2025

This PR changes two things:

  1. Removes dependency on libcuvs for wheel builds, as we clone and build from source to facilitate static link
  2. Removes dependency on cuvs for all builds

@divyegala divyegala requested a review from a team as a code owner September 23, 2025 19:06
@github-actions github-actions Bot added conda conda issue Cython / Python Cython or Python issue labels Sep 23, 2025
@divyegala divyegala added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change and removed conda conda issue Cython / Python Cython or Python issue labels Sep 23, 2025
@KyleFromNVIDIA KyleFromNVIDIA requested a review from a team as a code owner September 23, 2025 21:27
@github-actions github-actions Bot added conda conda issue Cython / Python Cython or Python issue CMake CUDA/C++ labels Sep 23, 2025
@divyegala divyegala requested a review from a team as a code owner September 24, 2025 19:53
@divyegala divyegala requested a review from jcrist September 24, 2025 19:53
- cuda-version=12.9
- cudf==25.10.*,>=0.0.0a0
- cupy>=13.6.0
- cuvs==25.10.*,>=0.0.0a0
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you remove this will setting up dev environments be impacted ?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, this is intentional. We have never had a dependency on cuvs python package, so this dependency was wrongly expressed. There should be no side-effects to removing this.

@csadorf csadorf removed the request for review from jcrist September 24, 2025 20:19
@csadorf
Copy link
Copy Markdown
Contributor

csadorf commented Sep 25, 2025

/merge

@rapids-bot rapids-bot Bot merged commit c4c54b5 into rapidsai:branch-25.10 Sep 25, 2025
106 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CMake conda conda issue CUDA/C++ Cython / Python Cython or Python issue improvement Improvement / enhancement to an existing function non-breaking Non-breaking change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants