Deprecate convert_to_* methods in favor of as_* methods in cuml.ensemble#7254
Merged
rapids-bot[bot] merged 3 commits intorapidsai:branch-25.10from Sep 24, 2025
Merged
Conversation
This deprecates: - `convert_to_fil_model` in favor of `as_fil` - `convert_to_treelite_model` in favor of `as_treelite` These method names are more aligned with other conversion method names like `as_sklearn`, leading to a bit more uniform UX.
jcrist
added
Cython / Python
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Merged
hcho3
approved these changes
Sep 22, 2025
Comment on lines
+523
to
+529
| # XXX: Theoretically we could wrap `tl_handle` with `treelite.Model` to | ||
| # manage ownership, and keep the loaded model around. However, this | ||
| # only works if the `libtreelite` is ABI compatible with the one used | ||
| # by `cuml`. This is currently true for conda environments, but not for | ||
| # wheels where `cuml` and `treelite` use different manylinux ABIs. So | ||
| # for now we need to do this serialize-and-reload dance. If/when this | ||
| # is fixed we could instead store the loaded model and use that instead. |
Contributor
There was a problem hiding this comment.
Thanks for updating the comment. The language is clearer now.
betatim
approved these changes
Sep 23, 2025
Member
|
/merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This deprecates:
convert_to_fil_modelin favor ofas_filconvert_to_treelite_modelin favor ofas_treeliteThese method names are more aligned with other conversion method names like
as_sklearn, leading to a bit more uniform UX.Also updates a comment as mentioned here: #7249 (comment).