Expose some private attrs in cuml.accel#7197
Merged
rapids-bot[bot] merged 2 commits intorapidsai:branch-25.10from Sep 9, 2025
Merged
Expose some private attrs in cuml.accel#7197rapids-bot[bot] merged 2 commits intorapidsai:branch-25.10from
cuml.accel#7197rapids-bot[bot] merged 2 commits intorapidsai:branch-25.10from
Conversation
Previously we never exposed private attributes in `cuml.accel`'s proxy implementation. In most cases this is the correct choice, however some estimators have private attributes that downstream consumers may still use. Previously we exposed those as a one-off way. We now add a builtin mechanism, and expand support a bit. In particular, the `neighbors` classifiers now expose the `_tree` attribute (it's always `None`, but that should be supported by consumers). This was motivated by getting `cuml.accel` to work with `PyOD`.
jcrist
added
non-breaking
This line wasn't harming anything, but is also no longer needed.
jcrist
commented
Sep 8, 2025
|
|
||
| class TSNE(ProxyBase): | ||
| _gpu_class = cuml.manifold.TSNE | ||
| _not_implemented_attributes = frozenset(("n_iter_",)) |
Member
Author
There was a problem hiding this comment.
This isn't related to this PR, but was something I just noticed in passing. We added support for n_iter_ in #7142, but forget to remove this line.
Since the check is only hit on an AttributeError, having this here wasn't harming anything, but it's also not needed. Removing it in this PR to avoid pushing another 1-line PR.
Member
Author
|
With this PR I can confirm that the example in #6530 runs successfully under |
dantegd
approved these changes
Sep 9, 2025
Member
Author
|
/merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously we never exposed private attributes in
cuml.accel's proxy implementation. In most cases this is the correct choice, however some estimators have private attributes that downstream consumers may still use.Previously we exposed those as a one-off way. We now add a builtin mechanism, and expand support a bit. In particular, the
neighborsclassifiers now expose the_treeattribute (it's alwaysNone, but that should be supported by consumers).This was motivated by getting
cuml.accelto work withPyOD.Fixes #6530.