Note non-determinism in random projection transforms#7129
Merged
rapids-bot[bot] merged 1 commit intorapidsai:branch-25.10from Aug 22, 2025
Merged
Conversation
Due to an upstream cupy bug, mixing sparse/dense arrays may result in close but not perfectly reproducible results. This means that passing a sparse array to `GaussianRandomProjection.transform` (or a dense array to `SparseRandomProjection.transform`) won't produce exactly identical results each run, even with a `random_state` set. For now we document this limitation and relax the bounds on a flaky test.
dantegd
approved these changes
Aug 22, 2025
Member
Author
|
/merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Due to an upstream cupy bug (cupy/cupy#9323), mixing sparse/dense arrays may result in close but not perfectly reproducible results. This means that passing a sparse array to
GaussianRandomProjection.transform(or a dense array toSparseRandomProjection.transform) won't produce exactly identical results each run, even with arandom_stateset.For now we document this limitation and relax the bounds on a flaky test.