FIX Make GaussianNB more resilient#7113
Merged
rapids-bot[bot] merged 5 commits intorapidsai:branch-25.10from Aug 19, 2025
Merged
FIX Make GaussianNB more resilient#7113rapids-bot[bot] merged 5 commits intorapidsai:branch-25.10from
rapids-bot[bot] merged 5 commits intorapidsai:branch-25.10from
Conversation
Error out when users provide weird inputs instead of getting ourselves into a broken state.
jcrist
reviewed
Aug 14, 2025
betatim
added
improvement
jcrist
approved these changes
Aug 19, 2025
Member
|
/merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes the minimal changes needed so that
GaussianNBdoes not end up in a broken state where all common checks lead to aMemoryError. The basic fix was to check thatXandyhave the same number of samples and erroring out (instead of ploughing on).The sad thing is that to find this fix you had to run all the checks, find the first
MemoryErrorand then run that check with an increasing number of the checks that run before it. Once the memory error raises its head you know that something in the most recently added check must be causing a problem.towards #7100