Using int64_t for HDBSCAN and dropping int#7104
Merged
rapids-bot[bot] merged 59 commits intorapidsai:branch-25.12from Oct 10, 2025
Merged
Using int64_t for HDBSCAN and dropping int#7104rapids-bot[bot] merged 59 commits intorapidsai:branch-25.12from
int64_t for HDBSCAN and dropping int#7104rapids-bot[bot] merged 59 commits intorapidsai:branch-25.12from
Conversation
jinsolp
added
improvement
rapids-bot Bot
pushed a commit
to rapidsai/cuvs
that referenced
this pull request
Oct 10, 2025
Using `all_neighbors` mutual reachability feature to work towards deprecating `cuvs::neighbors::detail::reachability::mutual_reachability_graph` (related issue: #982). Also, changes `build_linkage` to use `int64_t`, because `all_neighbors::build` only supports `int64_t` types, and we will change HDBSCAN to use `int64_t` types in cuML as well. **This PR will break cuML** (which will be solved by rapidsai/cuml#7104) Waiting for #1016 to be merged. Authors: - Jinsol Park (https://github.com/jinsolp) Approvers: - Corey J. Nolet (https://github.com/cjnolet) - Tarang Jain (https://github.com/tarang-jain) URL: #1234
Contributor
Author
|
/merge |
Contributor
Author
|
/merge |
julianmi
pushed a commit
to julianmi/cuvs
that referenced
this pull request
Oct 13, 2025
Using `all_neighbors` mutual reachability feature to work towards deprecating `cuvs::neighbors::detail::reachability::mutual_reachability_graph` (related issue: rapidsai#982). Also, changes `build_linkage` to use `int64_t`, because `all_neighbors::build` only supports `int64_t` types, and we will change HDBSCAN to use `int64_t` types in cuML as well. **This PR will break cuML** (which will be solved by rapidsai/cuml#7104) Waiting for rapidsai#1016 to be merged. Authors: - Jinsol Park (https://github.com/jinsolp) Approvers: - Corey J. Nolet (https://github.com/cjnolet) - Tarang Jain (https://github.com/tarang-jain) URL: rapidsai#1234
enp1s0
pushed a commit
to enp1s0/cuvs
that referenced
this pull request
Oct 22, 2025
Using `all_neighbors` mutual reachability feature to work towards deprecating `cuvs::neighbors::detail::reachability::mutual_reachability_graph` (related issue: rapidsai#982). Also, changes `build_linkage` to use `int64_t`, because `all_neighbors::build` only supports `int64_t` types, and we will change HDBSCAN to use `int64_t` types in cuML as well. **This PR will break cuML** (which will be solved by rapidsai/cuml#7104) Waiting for rapidsai#1016 to be merged. Authors: - Jinsol Park (https://github.com/jinsolp) Approvers: - Corey J. Nolet (https://github.com/cjnolet) - Tarang Jain (https://github.com/tarang-jain) URL: rapidsai#1234
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #7022
Changing default index type of HDBSCAN to
int64.Waiting for the following to be merged
IdxTusage in HDBSCAN #7023all_neighborsfor mutual reachability cuvs#1234This is a breaking change for cpp, but nothing will change for the python users.