Skip to content

Fix accel profiler 2x count of some fallback methods#7101

Merged
rapids-bot[bot] merged 2 commits intorapidsai:branch-25.10from
jcrist:cuml-accel-profile-double-count
Aug 11, 2025
Merged

Fix accel profiler 2x count of some fallback methods#7101
rapids-bot[bot] merged 2 commits intorapidsai:branch-25.10from
jcrist:cuml-accel-profile-double-count

Conversation

@jcrist
Copy link
Copy Markdown
Member

@jcrist jcrist commented Aug 8, 2025

Previously estimator methods that fell back to CPU due to unsupported arguments (not hyperparmeters) were accidentally double counted (once on GPU once on CPU). This fixes that and adds a test.

Previously estimator methods that fell back to CPU due to unsupported
arguments (not hyperparmeters) were accidentally double counted (once on
GPU once on CPU). This fixes that and adds a test.
@jcrist jcrist self-assigned this Aug 8, 2025
@jcrist jcrist requested a review from a team as a code owner August 8, 2025 19:03
@jcrist jcrist requested a review from csadorf August 8, 2025 19:03
@jcrist jcrist added the non-breaking Non-breaking change label Aug 8, 2025
@jcrist jcrist requested a review from divyegala August 8, 2025 19:03
@jcrist jcrist added the cuml-accel Issues related to cuml.accel label Aug 8, 2025
@github-actions github-actions Bot added the Cython / Python Cython or Python issue label Aug 8, 2025
@jcrist jcrist added the bug Something isn't working label Aug 8, 2025
@jcrist
Copy link
Copy Markdown
Member Author

jcrist commented Aug 11, 2025

/merge

@rapids-bot rapids-bot Bot merged commit 53a9ace into rapidsai:branch-25.10 Aug 11, 2025
71 checks passed
@jcrist jcrist deleted the cuml-accel-profile-double-count branch August 11, 2025 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working cuml-accel Issues related to cuml.accel Cython / Python Cython or Python issue non-breaking Non-breaking change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants