Add more estimators to the compatibility test suite#7069
Add more estimators to the compatibility test suite#7069rapids-bot[bot] merged 6 commits intorapidsai:branch-25.10from
Conversation
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
|
/ok to test |
|
IMHO we can already merge this, even though there are more estimators that could be added. The CI gods are looking favourably on this PR right now, and the diff is already large. |
csadorf
left a comment
There was a problem hiding this comment.
LGTM, just one question.
|
After fixing the imports and adding more xfails and skipping more tests I am now at a point where estimators like Seems like a bit of a dead end to work on this without fixing what ever underlying problem is causing this, because there isn't much point is skipping all the checks. |
|
The memory error that you see a lot is variations on this: You can run the tests with |
|
I'd suggest to split off the |
|
We can completely skip |
364b8c6 to
040b9be
Compare
|
Ok, I like this solution better: we skip the naive bayes estimators as they are the ones that cause the problems. All the other estimators are tested. |
csadorf
left a comment
There was a problem hiding this comment.
Pre-approving since this generally LGTM, but I'd ask that we reference relevant issues in-code wherever applicable.
607d2ea to
587e6d5
Compare
|
/merge |
e8b1405
into
rapidsai:branch-25.10
This adds more estimators and xfails for them to the compatibility test suite.
This is step 1 for #7061
Along the way I'm creating issues for issues that arise when running the checks that are more serious (aka we can't just mark the check as xfail). They should all refer to #7061 so you can see them there