UMAP multi-gpu knn graph build docs#7019
UMAP multi-gpu knn graph build docs#7019rapids-bot[bot] merged 12 commits intorapidsai:branch-25.08from
Conversation
jinsolp
added
doc
| if not ( | ||
| found_doc.type.startswith("cuml.Handle") | ||
| and klass == cuml.manifold.umap.UMAP | ||
| ): | ||
| # Ensure the docstring is identical | ||
| assert ( | ||
| found_doc.type == base_item_doc.type | ||
| ), "Docstring mismatch for {}".format(name) |
There was a problem hiding this comment.
The need for the exceptional handling here hints at an abstraction issue. This test ensures that the base class parameters and its children have the same signature for parameters of the same name. We need the exception because this is no longer the case, the UMAP class has a different signature.
A "correct" fix could be to either actually change the signature of the Base class such that it generally accepts instances of either cuml.Handle or pylibraft.common.DeviceResourcesSNMG type or ensure that cuml.Handle is either dervied from DeviceResourcesSNMG or at least shares a common base class.
We should not make any attempt at fixing or addressing this in this PR since it was originally introduced in #6654.
I suggest that we maintain this state for now and evaluate independently whether a correction is needed.
|
/merge |
rapids-bot
Bot
merged commit 84494e8
into
rapidsai:branch-25.08
5 participants
Closes #6856