Revamp cuml.accel limitations docs page#6965
Merged
rapids-bot[bot] merged 2 commits intorapidsai:branch-25.08from Jul 3, 2025
Merged
Revamp cuml.accel limitations docs page#6965rapids-bot[bot] merged 2 commits intorapidsai:branch-25.08from
cuml.accel limitations docs page#6965rapids-bot[bot] merged 2 commits intorapidsai:branch-25.08from
Conversation
This is a rewrite of the limitations docs page for `cuml.accel`. It:
- Improves the organization and formatting to make things more readable.
In particular, the headings and sidebar are now much more readable and
don't line wrap in weird places.
- Improves the uniformity across estimators. The old page had multiple
authors, leading to a bit of disjoint formatting and content.
- Ensures for every estimator we include:
- When we fallback to CPU and why (and that this matches the
implementation).
- What fitted attributes are currently missing
- What methods will always fallback to CPU
- How to compare results between sklearn and cuml.accel (when
relevant).
- Also added some general guidance on when and why a model might
fallback.
Member
Author
|
Going back over every wrapped estimator was a useful exercise - I've found a few cases where our logic was incorrect (and we should be falling back). This docs page matches what the code currently does - once this is in, I'll push a small followup PR fixing a few improperly handled hyperparams (and updating the doc accordingly). |
csadorf
requested changes
Jul 3, 2025
Contributor
csadorf
left a comment
csadorf
left a comment
There was a problem hiding this comment.
Great improvement! Just a few minor change requests.
Member
Author
|
Thanks, I believe I've addressed all points. |
Contributor
|
/merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a rewrite of the limitations docs page for
cuml.accel. It:Fixes #6956.