Support set_output and get_feature_names_out in cuml.accel#6942
Merged
rapids-bot[bot] merged 4 commits intorapidsai:branch-25.08from Jun 30, 2025
Merged
Support set_output and get_feature_names_out in cuml.accel#6942rapids-bot[bot] merged 4 commits intorapidsai:branch-25.08from
set_output and get_feature_names_out in cuml.accel#6942rapids-bot[bot] merged 4 commits intorapidsai:branch-25.08from
Conversation
jcrist
added
Cython / Python
jcrist
commented
Jun 27, 2025
Member
Author
jcrist
left a comment
jcrist
left a comment
There was a problem hiding this comment.
A few comments for reviewers
This adds support for `set_output` and `get_feature_names_out` in `cuml.accel` wrapped estimators.
umap-learn <= 0.5.7 doesn't properly implement `get_feature_names_out`; this method won't match the proper signature until then. Rather than hack around this in `cuml-accel` to fit the incorrect signature in `umap-learn`, I'd rather xfail this test for now. There is very little likelihood of a user actually running into this. `umap.UMAP` doesn't subclass from `TransformerMixin`, which means it doesn't have a `set_output` method (the only reason `get_feature_names_out` would be called in the wild).
jcrist
force-pushed
the
cuml-accel-set-output
branch
from
1b2315d to
1095b41
Compare
csadorf
approved these changes
Jun 30, 2025
Contributor
csadorf
left a comment
csadorf
left a comment
There was a problem hiding this comment.
Thank you very much for the detailed commentary motivating various choices.
LGTM, but I'm a bit surprised that it has not led to a reduction in the number of xfailed tests.
Member
Author
I was also a bit surprised by that. AFAICT sklearn doesn't test |
Member
Author
|
/merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds support for
set_outputandget_feature_names_outincuml.accel. This API addition affects anyTransformerexposed throughcuml.accel(currently onlyKMeans,TSNE,PCA, andTruncatedSVD). The support is automatic and implemented in theProxyBaseclass, so any newly wrapped estimators should automatically support it. Likewise, a test is added to auto-test any estimators exposing these methods.Fixes #6606.