Deprecate penalty='none' in MBSGDClassifier/MBSGDRegressor/SGD#6926
Merged
rapids-bot[bot] merged 6 commits intorapidsai:branch-25.08from Jun 25, 2025
Merged
Deprecate penalty='none' in MBSGDClassifier/MBSGDRegressor/SGD#6926rapids-bot[bot] merged 6 commits intorapidsai:branch-25.08from
penalty='none' in MBSGDClassifier/MBSGDRegressor/SGD#6926rapids-bot[bot] merged 6 commits intorapidsai:branch-25.08from
Conversation
We'd already done this for other linear estimators, MBSGD* just got missed.
No need to xfail these.
jcrist
added
improvement
betatim
reviewed
Jun 25, 2025
betatim
reviewed
Jun 25, 2025
betatim
reviewed
Jun 25, 2025
betatim
reviewed
Jun 25, 2025
betatim
reviewed
Jun 25, 2025
betatim
approved these changes
Jun 25, 2025
Member
betatim
left a comment
betatim
left a comment
There was a problem hiding this comment.
A few typos and a suggestion to make the pytest.warns more specific. Otherwise LGTM
Member
Author
|
/merge |
csadorf
added
breaking
csadorf
approved these changes
Jun 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We'd already deprecated
penalty='none'in favor ofpenalty=Nonefor other estimators, just not these. Switching topenalty=Noneeverywhere is more uniform and also improves compatibility with sklearn.Also:
penaltyto match the valid options