Restore old behavior for threshold in FIL#6922
Merged
rapids-bot[bot] merged 6 commits intorapidsai:branch-25.08from Jun 25, 2025
Merged
Restore old behavior for threshold in FIL#6922rapids-bot[bot] merged 6 commits intorapidsai:branch-25.08from
threshold in FIL#6922rapids-bot[bot] merged 6 commits intorapidsai:branch-25.08from
Conversation
hcho3
added
improvement
csadorf
requested changes
Jun 25, 2025
Co-authored-by: Simon Adorf <sadorf@nvidia.com>
csadorf
approved these changes
Jun 25, 2025
Contributor
|
/merge |
rapids-bot Bot
pushed a commit
that referenced
this pull request
Jul 1, 2025
Closes #6825 Requires #6922 to fix the CI Authors: - Philip Hyunsu Cho (https://github.com/hcho3) Approvers: - James Lamb (https://github.com/jameslamb) URL: #6923
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the old FIL,
load()accepted the optionalthresholdparameter for binary classifiers. The new FIL moves the parameter topredict(). To avoid breaking existing user code, we should continue acceptingthresholdinload(), until 25.10.