Skip to content

Add capability to use different allocators in cuML Python benchmarks#6903

Merged
rapids-bot[bot] merged 7 commits intorapidsai:branch-25.10from
dantegd:2508-bench-allocators
Sep 29, 2025
Merged

Add capability to use different allocators in cuML Python benchmarks#6903
rapids-bot[bot] merged 7 commits intorapidsai:branch-25.10from
dantegd:2508-bench-allocators

Conversation

@dantegd
Copy link
Copy Markdown
Member

@dantegd dantegd commented Jun 12, 2025

PR adds a new CLI option to run_benchmarks.py to set up different RMM allocators.

@copy-pr-bot
Copy link
Copy Markdown

copy-pr-bot Bot commented Jun 12, 2025

Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

@github-actions github-actions Bot added the Cython / Python Cython or Python issue label Jun 12, 2025
Comment thread python/cuml/cuml/benchmark/run_benchmarks.py Outdated
Comment thread python/cuml/cuml/benchmark/run_benchmarks.py Outdated
Comment thread python/cuml/cuml/benchmark/run_benchmarks.py Outdated
@csadorf
Copy link
Copy Markdown
Contributor

csadorf commented Jul 22, 2025

I suggest we re-target this to 25.10.

@csadorf csadorf changed the base branch from branch-25.08 to branch-25.10 July 28, 2025 21:29
@dantegd dantegd added feature request New feature or request non-breaking Non-breaking change improvement Improvement / enhancement to an existing function and removed feature request New feature or request labels Sep 25, 2025
@dantegd dantegd marked this pull request as ready for review September 25, 2025 13:12
@dantegd dantegd requested a review from a team as a code owner September 25, 2025 13:12
@dantegd dantegd requested a review from csadorf September 25, 2025 13:12
@csadorf
Copy link
Copy Markdown
Contributor

csadorf commented Sep 25, 2025

@dantegd Can you address the linter issues, please?

Copy link
Copy Markdown
Contributor

@csadorf csadorf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@csadorf
Copy link
Copy Markdown
Contributor

csadorf commented Sep 29, 2025

/merge

@rapids-bot rapids-bot Bot merged commit 8e6a0df into rapidsai:branch-25.10 Sep 29, 2025
190 of 192 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Cython / Python Cython or Python issue improvement Improvement / enhancement to an existing function non-breaking Non-breaking change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants