Change KMeans random_state default to None#6884
Merged
rapids-bot[bot] merged 1 commit intorapidsai:branch-25.08from Jun 11, 2025
Merged
Change KMeans random_state default to None#6884rapids-bot[bot] merged 1 commit intorapidsai:branch-25.08from
KMeans random_state default to None#6884rapids-bot[bot] merged 1 commit intorapidsai:branch-25.08from
Conversation
jcrist
added
Cython / Python
betatim
approved these changes
Jun 11, 2025
Member
betatim
left a comment
betatim
left a comment
There was a problem hiding this comment.
The universe has an endless supply of surprises!
Agree that this is a bug fix, hence I'd not call it a breaking change. But maybe that is just my weird definition where non breaking, breaking and bug fix are mutually exclusive categories 🤷
Member
Author
|
It's my understanding that adding the breaking label just elevates changes in the release notes - if that's the case then adding a label on changes that might be worth raising to a user's attention seems at worst harmless. |
Previously `random_state` defaulted to `1` (a fixed seed) rather than `None`. This PR changes the default to `None` to match that of every other estimator in `cuml`. This is a breaking change, but I'd view the previous behavior as unexpected and a bug.
jcrist
force-pushed
the
change-kmeans-random-state-default
branch
from
76a9e5c to
6f1e730
Compare
csadorf
approved these changes
Jun 11, 2025
Member
Author
|
/merge |
This was referenced Sep 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously
random_statedefaulted to1(a fixed seed) rather thanNone. This PR changes the default toNoneto match that of every other estimator incuml. This is a breaking change, but I'd view the previous behavior as unexpected and a bug.Fixes #6881.