Skip to content

Remove invalid xfail entry and mark correct test as flaky#6877

Merged
rapids-bot[bot] merged 3 commits intorapidsai:branch-25.08from
csadorf:remove-erroneous-xfail-entry
Jun 10, 2025
Merged

Remove invalid xfail entry and mark correct test as flaky#6877
rapids-bot[bot] merged 3 commits intorapidsai:branch-25.08from
csadorf:remove-erroneous-xfail-entry

Conversation

@csadorf
Copy link
Copy Markdown
Contributor

@csadorf csadorf commented Jun 10, 2025

  • Remove incorrect xfail entry for non-existent test test_roc_curve_display::test_fit_transform_csr_matrix[csr_matrix-exact]
  • Mark correct test test_fit_transform_csr_matrix[csr_matrix-exact] as flaky

@copy-pr-bot
Copy link
Copy Markdown

copy-pr-bot Bot commented Jun 10, 2025

Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

@github-actions github-actions Bot added the Cython / Python Cython or Python issue label Jun 10, 2025
@csadorf csadorf added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change tests Unit testing for project and removed improvement Improvement / enhancement to an existing function labels Jun 10, 2025
@csadorf csadorf force-pushed the remove-erroneous-xfail-entry branch from e5b591d to 7f6e3ee Compare June 10, 2025 17:02
@csadorf
Copy link
Copy Markdown
Contributor Author

csadorf commented Jun 10, 2025

/ok to test 7f6e3ee

Comment thread python/cuml/cuml/accel/tests/scikit-learn/xfail-list.yaml
@csadorf
Copy link
Copy Markdown
Contributor Author

csadorf commented Jun 10, 2025

/ok to test ba8b73b

@csadorf csadorf marked this pull request as ready for review June 10, 2025 17:59
@csadorf csadorf requested a review from a team as a code owner June 10, 2025 17:59
@csadorf csadorf requested review from divyegala and jcrist June 10, 2025 17:59
@csadorf csadorf changed the title Remove non-existent test_fit_transform_csr_matrix[csr_matrix-exact] xfail entry Mark test_fit_transform_csr_matrix[csr_matrix-exact] as flaky Jun 10, 2025
@csadorf csadorf changed the title Mark test_fit_transform_csr_matrix[csr_matrix-exact] as flaky Remove invalid xfail entry and mark correct test as flaky Jun 10, 2025
@jcrist
Copy link
Copy Markdown
Member

jcrist commented Jun 10, 2025

/merge

@rapids-bot rapids-bot Bot merged commit 848771e into rapidsai:branch-25.08 Jun 10, 2025
140 of 142 checks passed
@csadorf csadorf deleted the remove-erroneous-xfail-entry branch June 10, 2025 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Cython / Python Cython or Python issue improvement Improvement / enhancement to an existing function non-breaking Non-breaking change tests Unit testing for project

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants