Skip to content

Port cuml.ensemble to InteropMixin/ProxyBase#6863

Merged
rapids-bot[bot] merged 4 commits intorapidsai:branch-25.08from
jcrist:port-ensemble
Jun 11, 2025
Merged

Port cuml.ensemble to InteropMixin/ProxyBase#6863
rapids-bot[bot] merged 4 commits intorapidsai:branch-25.08from
jcrist:port-ensemble

Conversation

@jcrist
Copy link
Copy Markdown
Member

@jcrist jcrist commented Jun 5, 2025 •
edited
Loading

This ports RandomForestClassifier and RandomForestRegressor to subclass from InteropMixin and ProxyBase.

Fixes #6707.

Todo:

@copy-pr-bot
Copy link
Copy Markdown

copy-pr-bot Bot commented Jun 5, 2025

Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

@jcrist jcrist self-assigned this Jun 5, 2025
@github-actions github-actions Bot added the Cython / Python Cython or Python issue label Jun 5, 2025
@jcrist jcrist added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Jun 5, 2025
@hcho3
Copy link
Copy Markdown
Contributor

hcho3 commented Jun 10, 2025

@jcrist Do you need any help with this PR?

@jcrist
Copy link
Copy Markdown
Member Author

jcrist commented Jun 10, 2025

I do not, thanks though.

jcrist added 3 commits June 10, 2025 14:10
@jcrist
Port cuml.ensemble to InteropMixin/ProxyBase
e3ecf1a 
This ports `RandomForestClassifier` and `RandomForestRegressor` to
subclass from `InteropMixin` and `ProxyBase`.
@jcrist
Add interop tests
04a6138 
Also a few minor cleanups
@jcrist
Update xfail list
bcdd3fc
@jcrist jcrist changed the title [WIP] Port cuml.ensemble to InteropMixin/ProxyBase Port cuml.ensemble to InteropMixin/ProxyBase Jun 10, 2025
@jcrist jcrist marked this pull request as ready for review June 10, 2025 21:10
@jcrist jcrist requested a review from a team as a code owner June 10, 2025 21:10
@jcrist jcrist requested review from betatim and vyasr June 10, 2025 21:10
jcrist
jcrist commented Jun 10, 2025
View reviewed changes
Copy link
Copy Markdown
Member Author

@jcrist jcrist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright, this should be ready for review. Besides simplifying the RandomForest* internals this PR removed 80+ xfailing tests.

Comment thread python/cuml/cuml/accel/tests/scikit-learn/xfail-list.yaml
Comment thread python/cuml/cuml/ensemble/randomforest_common.pyx
csadorf
csadorf approved these changes Jun 10, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@csadorf csadorf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastic! LGTM!

Comment thread python/cuml/cuml/accel/tests/scikit-learn/xfail-list.yaml
@jcrist
Copy link
Copy Markdown
Member Author

jcrist commented Jun 11, 2025

/merge

@rapids-bot rapids-bot Bot merged commit 05426a0 into rapidsai:branch-25.08 Jun 11, 2025
67 checks passed
@jcrist jcrist deleted the port-ensemble branch June 11, 2025 15:28
@jcrist jcrist mentioned this pull request Jun 11, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@csadorf csadorf csadorf approved these changes

@betatim betatim Awaiting requested review from betatim betatim is a code owner automatically assigned from rapidsai/cuml-python-codeowners

@vyasr vyasr Awaiting requested review from vyasr vyasr is a code owner automatically assigned from rapidsai/cuml-python-codeowners

Assignees

@jcrist jcrist

Labels

Cython / Python Cython or Python issue improvement Improvement / enhancement to an existing function non-breaking Non-breaking change

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Port sklearn.ensemble proxies to use ProxyBase

4 participants

@jcrist @hcho3 @csadorf @GPUtester