Skip to content

Port KMeans to use ProxyBase/InteropMixin#6770

Merged
rapids-bot[bot] merged 5 commits intorapidsai:branch-25.06from
jcrist:port-kmeans
May 21, 2025
Merged

Port KMeans to use ProxyBase/InteropMixin#6770
rapids-bot[bot] merged 5 commits intorapidsai:branch-25.06from
jcrist:port-kmeans

Conversation

@jcrist
Copy link
Copy Markdown
Member

@jcrist jcrist commented May 20, 2025

This ports cuml.KMeans to use the new ProxyBase/InteropMixin architecture.

Part of #6705.

@jcrist jcrist requested a review from a team as a code owner May 20, 2025 17:09
@jcrist jcrist requested review from dantegd and teju85 May 20, 2025 17:09
@jcrist jcrist self-assigned this May 20, 2025
@github-actions github-actions Bot added the Cython / Python Cython or Python issue label May 20, 2025
@jcrist jcrist added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels May 20, 2025
jcrist added 2 commits May 21, 2025 08:06
This ports `cuml.KMeans` to use the new `ProxyBase`/`InteropMixin`
architecture.
@jcrist jcrist added the cuml-accel Issues related to cuml.accel label May 21, 2025
Comment thread python/cuml/cuml/accel/_wrappers/sklearn/cluster.py
Comment thread python/cuml/cuml/accel/estimator_proxy.py
Comment thread python/cuml/cuml/cluster/kmeans.pyx Outdated
Comment thread python/cuml/cuml/cluster/kmeans.pyx
Comment thread python/cuml/cuml/accel/estimator_proxy.py Outdated
Copy link
Copy Markdown
Contributor

@csadorf csadorf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks a lot!

@jcrist
Copy link
Copy Markdown
Member Author

jcrist commented May 21, 2025

/merge

@rapids-bot rapids-bot Bot merged commit 569b52e into rapidsai:branch-25.06 May 21, 2025
89 checks passed
@jcrist jcrist deleted the port-kmeans branch May 21, 2025 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cuml-accel Issues related to cuml.accel Cython / Python Cython or Python issue improvement Improvement / enhancement to an existing function non-breaking Non-breaking change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants