Use _assert_allclose function for approximate equality check.#6763
Merged
rapids-bot[bot] merged 1 commit intorapidsai:branch-25.06from May 20, 2025
Merged
Use _assert_allclose function for approximate equality check.#6763rapids-bot[bot] merged 1 commit intorapidsai:branch-25.06from
rapids-bot[bot] merged 1 commit intorapidsai:branch-25.06from
Conversation
This commit introduces a new helper function, _assert_allclose, to check if array-like data and cuml arrays are approximately equal using specified relative and absolute tolerances. The existing test case for binary operations has been updated to utilize this new function for adjusted precision in comparisons.
csadorf
added
bug
betatim
approved these changes
May 20, 2025
Member
betatim
left a comment
betatim
left a comment
There was a problem hiding this comment.
In principle fine for me.
One thing that would be nice, but bigger than this PR, is to somehow collect the various variations of allclose functions that seem to be defined across the tests.
Member
|
The failing test ( |
Contributor
Author
|
/merge |
Contributor
Author
I've created #6782 to capture that. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit introduces a new helper function, _assert_allclose, to check if array-like data and cuml arrays are approximately equal using specified relative and absolute tolerances. The existing test case for binary operations has been updated to utilize this new function for adjusted precision in comparisons.
Closes gh-6753