UMAP spectral initialization fallback to random on error#6750
Merged
rapids-bot[bot] merged 4 commits intorapidsai:branch-25.06from May 19, 2025
Merged
UMAP spectral initialization fallback to random on error#6750rapids-bot[bot] merged 4 commits intorapidsai:branch-25.06from
rapids-bot[bot] merged 4 commits intorapidsai:branch-25.06from
Conversation
Member
|
@btepera can you try your workflow with this PR and let us know how it goes? |
viclafargue
approved these changes
May 19, 2025
Contributor
There was a problem hiding this comment.
Thanks, @aamijar, LGTM. It might be a good idea to double-check that everything in spectral init is allocated following RAII principles to prevent potential memory leaks when throwing the exception.
divyegala
approved these changes
May 19, 2025
Member
|
/merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #6743