Skip to content

FIX: Set scikit-learn KMeans n_init=10 to match cuML#6727

Merged
rapids-bot[bot] merged 2 commits intorapidsai:branch-25.06from
csadorf:fix-kmeans-test-n-init
May 14, 2025
Merged

FIX: Set scikit-learn KMeans n_init=10 to match cuML#6727
rapids-bot[bot] merged 2 commits intorapidsai:branch-25.06from
csadorf:fix-kmeans-test-n-init

Conversation

@csadorf
Copy link
Copy Markdown
Contributor

@csadorf csadorf commented May 14, 2025

This PR sets scikit-learn's KMeans n_init=10 to match cuML's default value in the tests. This is a possible fix, but at least a mitigation for #6721 .

@copy-pr-bot
Copy link
Copy Markdown

copy-pr-bot Bot commented May 14, 2025

Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

@github-actions github-actions Bot added the Cython / Python Cython or Python issue label May 14, 2025
@csadorf csadorf self-assigned this May 14, 2025
@csadorf csadorf added bug Something isn't working tests Unit testing for project non-breaking Non-breaking change labels May 14, 2025
@csadorf csadorf marked this pull request as ready for review May 14, 2025 17:58
@csadorf csadorf requested a review from a team as a code owner May 14, 2025 17:58
@csadorf csadorf requested review from dantegd and teju85 May 14, 2025 17:58
@csadorf
Copy link
Copy Markdown
Contributor Author

csadorf commented May 14, 2025

/merge

1 similar comment
@csadorf
Copy link
Copy Markdown
Contributor Author

csadorf commented May 14, 2025

/merge

@rapids-bot rapids-bot Bot merged commit 4f3e897 into rapidsai:branch-25.06 May 14, 2025
87 of 89 checks passed
@csadorf csadorf deleted the fix-kmeans-test-n-init branch May 14, 2025 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working Cython / Python Cython or Python issue non-breaking Non-breaking change tests Unit testing for project

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Flaky test failure in test_traditional_kmeans_plus_plus_init with large score discrepancy

3 participants