-
Notifications
You must be signed in to change notification settings - Fork 623
Don't setup managed memory if rmm isn't using default settings #6700
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
rapids-bot
merged 3 commits into
rapidsai:branch-25.06
from
jcrist:cuml-accel-dont-modify-setup-mr
May 16, 2025
Merged
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,98 @@ | ||
| # Copyright (c) 2025, NVIDIA CORPORATION. | ||
| # | ||
| # Licensed under the Apache License, Version 2.0 (the "License"); | ||
| # you may not use this file except in compliance with the License. | ||
| # You may obtain a copy of the License at | ||
| # | ||
| # http://www.apache.org/licenses/LICENSE-2.0 | ||
| # | ||
| # Unless required by applicable law or agreed to in writing, software | ||
| # distributed under the License is distributed on an "AS IS" BASIS, | ||
| # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| # See the License for the specific language governing permissions and | ||
| # limitations under the License. | ||
|
|
||
| import subprocess | ||
| import sys | ||
| from textwrap import dedent | ||
|
|
||
| import pytest | ||
|
|
||
| pytest.importorskip("IPython") | ||
|
|
||
|
|
||
| SCRIPT_HEADER = """ | ||
| from IPython.core.interactiveshell import InteractiveShell | ||
| from traitlets.config import Config | ||
| c = Config() | ||
| c.HistoryManager.hist_file = ":memory:" | ||
| ip = InteractiveShell(config=c) | ||
| """ | ||
|
|
||
|
|
||
| def run_script(body): | ||
| script = SCRIPT_HEADER + dedent(body) | ||
|
|
||
| res = subprocess.run( | ||
| [sys.executable, "-c", script], | ||
| stderr=subprocess.STDOUT, | ||
| stdout=subprocess.PIPE, | ||
| text=True, | ||
| ) | ||
| # Pull out attributes before assert for nicer error reporting on failure | ||
| returncode = res.returncode | ||
| stdout = res.stdout | ||
| assert returncode == 0, stdout | ||
|
|
||
|
|
||
| def test_magic(): | ||
| run_script( | ||
| """ | ||
| ip.run_line_magic("load_ext", "cuml.accel") | ||
|
|
||
| # cuml.accel proxies setup properly | ||
| ip.run_cell("from sklearn.linear_model import LinearRegression") | ||
| ip.run_cell("from cuml.accel import is_proxy") | ||
| ip.run_cell("assert is_proxy(LinearRegression)").raise_error() | ||
| """ | ||
| ) | ||
|
|
||
|
|
||
| def test_magic_cudf_pandas_before(): | ||
| run_script( | ||
| """ | ||
| ip.run_line_magic("load_ext", "cudf.pandas") | ||
| ip.run_cell("import rmm; mr = rmm.mr.get_current_device_resource();") | ||
|
|
||
| ip.run_line_magic("load_ext", "cuml.accel") | ||
| ip.run_cell("mr2 = rmm.mr.get_current_device_resource();") | ||
|
|
||
| # cuml doesn't change the mr setup by cudf.pandas | ||
| ip.run_cell("assert mr is mr2").raise_error() | ||
|
|
||
| # cuml.accel proxies setup properly | ||
| ip.run_cell("from sklearn.linear_model import LinearRegression") | ||
| ip.run_cell("from cuml.accel import is_proxy") | ||
| result = ip.run_cell("assert is_proxy(LinearRegression)").raise_error() | ||
| """ | ||
| ) | ||
|
|
||
|
|
||
| def test_magic_cudf_pandas_after(): | ||
| run_script( | ||
| """ | ||
| ip.run_line_magic("load_ext", "cuml.accel") | ||
| ip.run_cell("import rmm; mr = rmm.mr.get_current_device_resource();") | ||
|
|
||
| ip.run_line_magic("load_ext", "cudf.pandas") | ||
| ip.run_cell("mr2 = rmm.mr.get_current_device_resource();") | ||
|
|
||
| # cudf.pandas doesn't change the mr setup by cuml.accel | ||
| ip.run_cell("assert mr is mr2").raise_error() | ||
|
|
||
| # cuml.accel proxies setup properly | ||
| ip.run_cell("from sklearn.linear_model import LinearRegression") | ||
| ip.run_cell("from cuml.accel import is_proxy") | ||
| result = ip.run_cell("assert is_proxy(LinearRegression)").raise_error() | ||
| """ | ||
| ) |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.