Port sklearn.decomposition to new proxy estimator structure#6695
Merged
rapids-bot[bot] merged 6 commits intorapidsai:branch-25.06from May 13, 2025
Merged
Port sklearn.decomposition to new proxy estimator structure#6695rapids-bot[bot] merged 6 commits intorapidsai:branch-25.06from
sklearn.decomposition to new proxy estimator structure#6695rapids-bot[bot] merged 6 commits intorapidsai:branch-25.06from
Conversation
jcrist
added
improvement
This is such a common check it makes sense to enclose it in the base class for now.
These tests previously used `PCA`/`TruncatedSVD`, which now subclass `ProxyBase`.
jcrist
force-pushed
the
port-sklearn-decomposition
branch
from
e2e6d2b to
5c39a7e
Compare
csadorf
reviewed
May 13, 2025
Contributor
csadorf
left a comment
csadorf
left a comment
There was a problem hiding this comment.
LGTM! I'm slightly surprised by the sklearn test regressions. Are those new tests, because we support more or what's going on?
Member
Author
|
/merge |
csadorf
approved these changes
May 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR:
PCAandTruncatedSVDto subclass fromBase&InteropMixininstead ofUniversalBasecuml.accelto subclass fromProxyBaseinstead ofProxyMixinProxyBaseto handle the sparse support checks in the base class rather than delegating these to the_gpu_*override methods. These checks are common, for now it makes sense to keep them in the base class (this is also how the olddispatch_funcmethod worked).Fixes #6706.