Adjust scikit-learn test failure handling#6646
Merged
rapids-bot[bot] merged 6 commits intorapidsai:branch-25.06from May 8, 2025
Merged
Adjust scikit-learn test failure handling#6646rapids-bot[bot] merged 6 commits intorapidsai:branch-25.06from
rapids-bot[bot] merged 6 commits intorapidsai:branch-25.06from
Conversation
This ensures that we continue to detect major regressions during nightly tests, but non-deterministic "xpasses" due to previously undetected flaky tests do not lead to a complete test failure. Regular test runs will continue to fail for all regressions, including strict passes so that we can detect improvements related to their changes.
csadorf
added
bug
18 tasks
jameslamb
approved these changes
May 8, 2025
jcrist
approved these changes
May 8, 2025
Contributor
Author
|
/merge |
Ofek-Haim
pushed a commit
to Ofek-Haim/cuml
that referenced
this pull request
May 13, 2025
- Fix test_sequential skip for CUDA 11.x by properly handling the skip condition - Modify test failure behavior to be more appropriate for different test scenarios: - Nightly tests: Only fail if pass rate threshold (85%) is not met - Regular test runs: Fail on any test failure to catch all regressions and improvements - Reduce verbosity of scikit-learn cuml.accel tests for cleaner test output - Increase scikit-learn test pass rate threshold from 80% to 85% to adjust for current pass rate. Authors: - Simon Adorf (https://github.com/csadorf) Approvers: - James Lamb (https://github.com/jameslamb) - Jim Crist-Harif (https://github.com/jcrist) URL: rapidsai#6646
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.