Fallback to CPU for T-SNE with Barnes Hut.#6637
Closed
csadorf wants to merge 5 commits intorapidsai:branch-25.06from
Closed
Fallback to CPU for T-SNE with Barnes Hut.#6637csadorf wants to merge 5 commits intorapidsai:branch-25.06from
csadorf wants to merge 5 commits intorapidsai:branch-25.06from
Conversation
Mitigation for rapidsai#6617.
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
Contributor
Author
|
/ok to test 01255a1 |
Contributor
Author
|
/ok to test da480a3 |
Contributor
Author
|
/ok to test 90cf433 |
dantegd
requested changes
May 7, 2025
| }, | ||
| "method": { | ||
| "exact": "exact", | ||
| "barnes_hut": "NotImplemented", |
Member
There was a problem hiding this comment.
Most users will default to Barnes hut since it's the default, so this will be very impactful for users of zero code change, and there is no good reason why we shouldn't change to fft here
Contributor
Author
There was a problem hiding this comment.
Can you weigh in on this discussion then?
Contributor
Author
|
Putting back into draft, we decided to proceed with #6619 for now. |
Member
|
Closing this for now since we went with #6619. Can always reopen later if needed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mitigation for #6617.