Skip to content

Enhance accelerator parity testing framework#6629

Merged
rapids-bot[bot] merged 9 commits intorapidsai:branch-25.06from
csadorf:work/cuml.accel-parity
May 7, 2025
Merged

Enhance accelerator parity testing framework#6629
rapids-bot[bot] merged 9 commits intorapidsai:branch-25.06from
csadorf:work/cuml.accel-parity

Conversation

@csadorf
Copy link
Copy Markdown
Contributor

@csadorf csadorf commented May 6, 2025

This PR enhances the accelerator parity testing framework with several improvements:

  • Refactors xfail list structure to better group tests by reason and failure type
  • Adds support for custom extra markers in test configuration
  • Documents workflow for fixing parity issues
  • Improves test result summarization with options to limit output and show tracebacks
  • Includes initial work on test failure triage

@csadorf csadorf requested a review from a team as a code owner May 6, 2025 22:25
@csadorf csadorf requested review from dantegd and viclafargue May 6, 2025 22:25
@github-actions github-actions Bot added the Cython / Python Cython or Python issue label May 6, 2025
@csadorf csadorf added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change and removed Cython / Python Cython or Python issue labels May 6, 2025
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately the diff on this will be unwieldy. You will have to trust me to a certain extent that the list is equivalent. The test runs should also reveal that though.

@csadorf csadorf linked an issue May 6, 2025 that may be closed by this pull request
@csadorf csadorf requested a review from betatim May 6, 2025 23:08
@github-actions github-actions Bot added the Cython / Python Cython or Python issue label May 6, 2025
@csadorf csadorf self-assigned this May 7, 2025
@csadorf
Copy link
Copy Markdown
Contributor Author

csadorf commented May 7, 2025

/merge

@rapids-bot rapids-bot Bot merged commit ffe8502 into rapidsai:branch-25.06 May 7, 2025
74 checks passed
@csadorf csadorf deleted the work/cuml.accel-parity branch May 7, 2025 18:57
@jcrist jcrist mentioned this pull request May 7, 2025
4 tasks
Ofek-Haim pushed a commit to Ofek-Haim/cuml that referenced this pull request May 13, 2025
This PR enhances the accelerator parity testing framework with several improvements:

- Refactors xfail list structure to better group tests by reason and failure type
- Adds support for custom extra markers in test configuration
- Documents workflow for fixing parity issues
- Improves test result summarization with options to limit output and show tracebacks
- Includes initial work on test failure triage

Authors:
  - Simon Adorf (https://github.com/csadorf)

Approvers:
  - Victor Lafargue (https://github.com/viclafargue)

URL: rapidsai#6629
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Cython / Python Cython or Python issue improvement Improvement / enhancement to an existing function non-breaking Non-breaking change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Adjust xfail list schema to allow for grouping of common test failures

2 participants