Compatibility with Dask 2025.4.1#6614
Merged
rapids-bot[bot] merged 6 commits intorapidsai:branch-25.06from May 7, 2025
Merged
Conversation
This fixes the tests `packages/cuml/python/cuml/cuml/tests/dask/test_dask_kneighbors_regressor.py::test_predict_and_score[dataset0-parameters0-dask_cudf]` failing at https://github.com/rapidsai/dask-upstream-testing/actions/runs/14830363253/job/41630210318#step:10:783. Most likely, a Future wasn't living long enough, and something wasn't capturing that ref. Workaround by keeping the reference around until we're done with it.
Fixes the failures in, e.g. packages/cuml/python/cuml/cuml/tests/dask/test_dask_label_binarizer.py::test_basic_functions[True-labels0] observed at https://github.com/rapidsai/dask-upstream-testing/actions/runs/14830363253/job/41630210318#step:10:788
This was referenced May 5, 2025
This changed in dask/distributed#9045. We always want everything.
TomAugspurger
commented
May 6, 2025
Contributor
Author
|
CI failure at https://github.com/rapidsai/cuml/actions/runs/14882476121/job/41794658828?pr=6614#step:9:3455 That appears to be unrelated but I'm not sure. |
Member
|
I've restarted the failed test. I think the failure of the QN test is a sign of a flaky test, I've had it fail a few times (and then not) in another PR this week |
Member
|
/merge |
TomAugspurger
added a commit
to TomAugspurger/cuml
that referenced
this pull request
May 8, 2025
Followup to rapidsai#6614
TomAugspurger
added a commit
to TomAugspurger/cuml
that referenced
this pull request
May 8, 2025
rapidsai#6614 broke BaseRandomForestModel for the "regressoin" op type. In this case, the shape we provided Dask was wrong, which eventually caused errors in `dask.array.concatenate` trying to convert cupy arrays to ndarrays. I'm not sure why CI didn't catch this. Perhaps older versions of dask weren't susceptible to this issue.
rapids-bot Bot
pushed a commit
that referenced
this pull request
May 9, 2025
Followup to #6614. Fixes the failure observed at https://github.com/rapidsai/dask-upstream-testing/actions/runs/14906047179/job/41868578062#step:10:1208. Authors: - Tom Augspurger (https://github.com/TomAugspurger) Approvers: - Simon Adorf (https://github.com/csadorf) URL: #6645
Ofek-Haim
pushed a commit
to Ofek-Haim/cuml
that referenced
this pull request
May 13, 2025
This PR is another attempt at fixing compatibility with dask upstreaming, targeting dask==2025.4.1 rapidsai/dask-upstream-testing#44 and linked CI runs as the list of failures. This PR fixes the first two classes of failures, one set in `LabelBinarizer` and one set in kneighbors. See the commit messages for links to failures. ~There's one remaining class of failures in `cuml/python/cuml/cuml/tests/dask/test_dask_random_forest.py::test_rf_broadcast[True-True-classification]`. I'm currently planning to fix those in a separate PR since it looks more complicated.~ These should be fixed by [1d75861](rapidsai@1d75861) and [22393bb](rapidsai@22393bb). Authors: - Tom Augspurger (https://github.com/TomAugspurger) Approvers: - Jim Crist-Harif (https://github.com/jcrist) URL: rapidsai#6614
Ofek-Haim
pushed a commit
to Ofek-Haim/cuml
that referenced
this pull request
May 13, 2025
Followup to rapidsai#6614. Fixes the failure observed at https://github.com/rapidsai/dask-upstream-testing/actions/runs/14906047179/job/41868578062#step:10:1208. Authors: - Tom Augspurger (https://github.com/TomAugspurger) Approvers: - Simon Adorf (https://github.com/csadorf) URL: rapidsai#6645
rapids-bot Bot
pushed a commit
to rapidsai/rapids-dask-dependency
that referenced
this pull request
May 15, 2025
For the next rapids release (25.06) I'd like to target Dask==2025.4.1. Currently, the only known failures with dask main are at rapidsai/dask-upstream-testing#44, which should be fixed by rapidsai/cuml#6614. My rough plan is 1. Get that cuml PR merged. 2. Confirm a successful run against dask main 3. Confirm a successful run against dask==2025.4.1 (using rapidsai/dask-upstream-testing#45, hopefully; hardcoding the branch temporaily if not) 4. Monitor CI for downstream libraries to confirm that dask==2025.4.1 is picked up and CI passes. Closes rapidsai/cudf#18122 Authors: - Tom Augspurger (https://github.com/TomAugspurger) Approvers: - Richard (Rick) Zamora (https://github.com/rjzamora) URL: #95
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is another attempt at fixing compatibility with dask upstreaming, targeting dask==2025.4.1
rapidsai/dask-upstream-testing#44 and linked CI runs as the list of failures. This PR fixes the first two classes of failures, one set in
LabelBinarizerand one set in kneighbors. See the commit messages for links to failures.There's one remaining class of failures inThese should be fixed by 1d75861 and 22393bb.cuml/python/cuml/cuml/tests/dask/test_dask_random_forest.py::test_rf_broadcast[True-True-classification]. I'm currently planning to fix those in a separate PR since it looks more complicated.