Remove cuml.common.cuda#6600
Merged
rapids-bot[bot] merged 5 commits intorapidsai:branch-25.06from Apr 29, 2025
Merged
Conversation
These were all outdated anyway. The tests that were changed were broken before (but were xfailed already for other reasons). The docstrings were outdated.
This file only contained dead code. It's been superseded by the contents in `pylibraft`.
This is all dead code, and all imports of it were unneeded.
jcrist
added
improvement
betatim
reviewed
Apr 29, 2025
betatim
approved these changes
Apr 29, 2025
Member
betatim
left a comment
betatim
left a comment
There was a problem hiding this comment.
Much tidy, such clean up, amaze!
Contributor
|
/merge |
Merged
Ofek-Haim
pushed a commit
to Ofek-Haim/cuml
that referenced
this pull request
May 13, 2025
This is all dead code (effectively superseded by `pylibraft`). All internal references to it were broken (only used in xfailed tests that were xfailed for other reasons then bitrotted), incorrect docstrings, or unnecessary cython `cimport`s. Also removes `cuml/common/handle.pyx`. This only existed to re-export `pylibraft.common.Handle`, but all public references point to `cuml.Handle` (or the `pylibraft` namespace directly). No need to include a cython module just to re-export a single class. Authors: - Jim Crist-Harif (https://github.com/jcrist) Approvers: - Tim Head (https://github.com/betatim) - Bradley Dice (https://github.com/bdice) URL: rapidsai#6600
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is all dead code (effectively superseded by
pylibraft). All internal references to it were broken (only used in xfailed tests that were xfailed for other reasons then bitrotted), incorrect docstrings, or unnecessary cythoncimports.Also removes
cuml/common/handle.pyx. This only existed to re-exportpylibraft.common.Handle, but all public references point tocuml.Handle(or thepylibraftnamespace directly). No need to include a cython module just to re-export a single class.