Skip to content

Add timeout to scikit-learn test suite#6591

Merged
rapids-bot[bot] merged 1 commit intorapidsai:branch-25.06from
jcrist:timeout-ci
Apr 28, 2025
Merged

Add timeout to scikit-learn test suite#6591
rapids-bot[bot] merged 1 commit intorapidsai:branch-25.06from
jcrist:timeout-ci

Conversation

@jcrist
Copy link
Copy Markdown
Member

@jcrist jcrist commented Apr 25, 2025

These sometimes hang, but usually run in < 30 mins. Adding a timeout to catch hung test runs earlier.

@jcrist jcrist added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change ci labels Apr 25, 2025
@jcrist jcrist requested a review from a team as a code owner April 25, 2025 19:10
@jcrist jcrist requested a review from KyleFromNVIDIA April 25, 2025 19:10
@jcrist jcrist self-assigned this Apr 25, 2025
@jcrist
Copy link
Copy Markdown
Member Author

jcrist commented Apr 25, 2025

Holdoff, will rebase on #6553 once that's merged.

edit: done

These sometimes hang, but usually run in < 30 mins. Adding a timeout to
catch hung test runs earlier.
@csadorf
Copy link
Copy Markdown
Contributor

csadorf commented Apr 28, 2025

/merge

@rapids-bot rapids-bot Bot merged commit 808836a into rapidsai:branch-25.06 Apr 28, 2025
77 of 78 checks passed
@csadorf
Copy link
Copy Markdown
Contributor

csadorf commented Apr 28, 2025

For reference, we experienced more hangs on CUDA 11.8 in recent nightlies that will not be fixed by this PR, but more quickly detected:

@jcrist jcrist deleted the timeout-ci branch April 28, 2025 17:38
Ofek-Haim pushed a commit to Ofek-Haim/cuml that referenced this pull request May 13, 2025
These sometimes hang, but usually run in < 30 mins. Adding a timeout to catch hung test runs earlier.

Authors:
  - Jim Crist-Harif (https://github.com/jcrist)

Approvers:
  - Gil Forsyth (https://github.com/gforsyth)
  - Simon Adorf (https://github.com/csadorf)

URL: rapidsai#6591
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci improvement Improvement / enhancement to an existing function non-breaking Non-breaking change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants