Don't run memleak tests in CI#6583
Merged
rapids-bot[bot] merged 2 commits intorapidsai:branch-25.06from Apr 24, 2025
Merged
Conversation
`cuml` has a few `memleak` tests. These are currently all xfailed due to flakiness in CI (or poor measurement of "is this a memleak"). Currently we skip them manually with `-m "not memleak"` in _most_ (but not all) test runs, and have a dedicated run for them in the nightlies. However, since all memleak tests are xfailed, the nightly run (which takes 18 mins per build) provides no signal. These just aren't currently good tests. I was encouraged offline to keep the test code around. Rather than fully delete them, I've: - Made the `memleak` marker skip by default. You need to invoke pytest with `--run_memleak` to run the memleak tests. This means these tests no longer run on any build. - Removed the run of them memleak tests from nightly CI. - Removed some vestiges of trying to skip them in certain runs. We skip them by default now, no need to manually specify skipping.
jcrist
added
improvement
bdice
approved these changes
Apr 24, 2025
Member
Author
|
/merge |
Ofek-Haim
pushed a commit
to Ofek-Haim/cuml
that referenced
this pull request
May 13, 2025
`cuml` has a few `memleak` tests. These are currently all xfailed due to flakiness in CI (or poor measurement of "is this a memleak"). Currently we skip them manually with `-m "not memleak"` in _most_ (but not all) test runs, and have a dedicated run for them in the nightlies. However, since all memleak tests are xfailed, the nightly run (which takes 18 mins per build) provides no signal. These just aren't currently good tests. I was encouraged offline to keep the test code around. Rather than fully delete them, I've: - Made the `memleak` marker skip by default. You need to invoke pytest with `--run_memleak` to run the memleak tests. This means these tests no longer run on any build. - Removed the run of them memleak tests from nightly CI. - Removed some vestiges of trying to skip them in certain runs. We skip them by default now, no need to manually specify skipping. Fixes rapidsai#6475. Authors: - Jim Crist-Harif (https://github.com/jcrist) Approvers: - Bradley Dice (https://github.com/bdice) URL: rapidsai#6583
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cumlhas a fewmemleaktests. These are currently all xfailed due to flakiness in CI (or poor measurement of "is this a memleak"). Currently we skip them manually with-m "not memleak"in most (but not all) test runs, and have a dedicated run for them in the nightlies. However, since all memleak tests are xfailed, the nightly run (which takes 18 mins per build) provides no signal. These just aren't currently good tests.I was encouraged offline to keep the test code around. Rather than fully delete them, I've:
memleakmarker skip by default. You need to invoke pytest with--run_memleakto run the memleak tests. This means these tests no longer run on any build.Fixes #6475.