Skip to content

Fix launch parameters for kernel shap#6577

Merged
rapids-bot[bot] merged 3 commits intobranch-25.06from
bug-kernel-shap-launch
Apr 24, 2025
Merged

Fix launch parameters for kernel shap#6577
rapids-bot[bot] merged 3 commits intobranch-25.06from
bug-kernel-shap-launch

Conversation

@divyegala
Copy link
Copy Markdown
Member

sampled_rows_kernel launches one extra block when the number of samples is even and attempts to modify an out-of-bounds memory location.

@divyegala divyegala added bug Something isn't working non-breaking Non-breaking change labels Apr 23, 2025
@divyegala divyegala self-assigned this Apr 23, 2025
@divyegala divyegala requested a review from a team as a code owner April 23, 2025 18:28
@divyegala divyegala requested review from viclafargue and vyasr April 23, 2025 18:28
@copy-pr-bot
Copy link
Copy Markdown

copy-pr-bot Bot commented Apr 23, 2025

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@divyegala
Copy link
Copy Markdown
Member Author

/ok to test 4aa58a8

@divyegala
Copy link
Copy Markdown
Member Author

/merge

@rapids-bot rapids-bot Bot merged commit 0695d09 into branch-25.06 Apr 24, 2025
75 of 77 checks passed
Ofek-Haim pushed a commit to Ofek-Haim/cuml that referenced this pull request May 13, 2025
`sampled_rows_kernel` launches one extra block when the number of samples is even and attempts to modify an out-of-bounds memory location.

Authors:
  - Divye Gala (https://github.com/divyegala)

Approvers:
  - Dante Gama Dessavre (https://github.com/dantegd)

URL: rapidsai#6577
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working CUDA/C++ non-breaking Non-breaking change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants