Remove conditional compilation blocks leftover from cuml-cpu#6572
Merged
rapids-bot[bot] merged 23 commits intorapidsai:branch-25.06from Apr 24, 2025
Merged
Remove conditional compilation blocks leftover from cuml-cpu#6572rapids-bot[bot] merged 23 commits intorapidsai:branch-25.06from
cuml-cpu#6572rapids-bot[bot] merged 23 commits intorapidsai:branch-25.06from
Conversation
gforsyth
approved these changes
Apr 22, 2025
Contributor
gforsyth
left a comment
gforsyth
left a comment
There was a problem hiding this comment.
build.sh changes look good.
bdice
approved these changes
Apr 22, 2025
Contributor
|
Please hold off merge until I can complete my review. |
csadorf
requested changes
Apr 22, 2025
csadorf
approved these changes
Apr 22, 2025
8 tasks
Member
Author
|
/merge |
Ofek-Haim
pushed a commit
to Ofek-Haim/cuml
that referenced
this pull request
May 13, 2025
…sai#6572) We're no longer releasing builds of `cuml-cpu`. This PR: - Removes the previous `IF GPUBUILD` blocks used to conditionally guard compilation for `cuml-cpu` builds. I didn't remove or simplify the usage of `gpu_only_import`/`cpu_only_import`, this PR is only tackling removal of the conditional compilation. - Removes setting `GPUBUILD` in the cmake file - Since the latter effectively breaks `cuml-cpu` builds, I went ahead and fully removed `cuml-cpu` from our cmake setup. Fixes rapidsai#6231. Part of rapidsai#6523. Authors: - Jim Crist-Harif (https://github.com/jcrist) Approvers: - Gil Forsyth (https://github.com/gforsyth) - Bradley Dice (https://github.com/bdice) - Simon Adorf (https://github.com/csadorf) URL: rapidsai#6572
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We're no longer releasing builds of
cuml-cpu. This PR:IF GPUBUILDblocks used to conditionally guard compilation forcuml-cpubuilds. I didn't remove or simplify the usage ofgpu_only_import/cpu_only_import, this PR is only tackling removal of the conditional compilation.GPUBUILDin the cmake filecuml-cpubuilds, I went ahead and fully removedcuml-cpufrom our cmake setup.Fixes #6231. Part of #6523.