Don't exclude sklearn tests from acceleration#6565
Merged
rapids-bot[bot] merged 1 commit intorapidsai:branch-25.06from Apr 22, 2025
Merged
Conversation
When we rewrote `cuml.accel`'s mechanism to use a finder and loader (and include a `denylist` for excluding certain modules from acceleration), we accidentally excluded the `sklearn` tests from acceleration. We don't want to do this since we run the sklearn test suite with `cuml.accel` enabled to validate our implementation. This PR: - Renames `denylist` to `exclude` - Makes `exclude` optionally take a callable instead of a sequence - Updates our exclude logic for `cuml.accel` to exempt modules matching `sklearn.*.tests.*` from exclusion.
jcrist
added
improvement
csadorf
approved these changes
Apr 22, 2025
Contributor
csadorf
left a comment
csadorf
left a comment
There was a problem hiding this comment.
Awesome! Thanks for addressing this so quickly!
Member
Author
|
/merge |
Ofek-Haim
pushed a commit
to Ofek-Haim/cuml
that referenced
this pull request
May 13, 2025
When we rewrote `cuml.accel`'s mechanism to use a finder and loader (and include a `denylist` for excluding certain modules from acceleration), we accidentally excluded the `sklearn` tests from acceleration. We don't want to do this since we run the sklearn test suite with `cuml.accel` enabled to validate our implementation. This PR: - Renames `denylist` to `exclude` - Makes `exclude` optionally take a callable instead of a sequence - Updates our exclude logic for `cuml.accel` to exempt modules matching `sklearn.*.tests.*` from exclusion. Authors: - Jim Crist-Harif (https://github.com/jcrist) Approvers: - Simon Adorf (https://github.com/csadorf) URL: rapidsai#6565
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When we rewrote
cuml.accel's mechanism to use a finder and loader (and include adenylistfor excluding certain modules from acceleration), we accidentally excluded thesklearntests from acceleration. We don't want to do this since we run the sklearn test suite withcuml.accelenabled to validate our implementation.This PR:
denylisttoexcludeexcludeoptionally take a callable instead of a sequencecuml.accelto exempt modules matchingsklearn.*.tests.*from exclusion.