Skip to content

Update FIL Model Loading Parameter in FIL demo notebook#6562

Merged
rapids-bot[bot] merged 1 commit intorapidsai:branch-25.06from
csadorf:fix/docker-issue-749
Apr 21, 2025
Merged

Update FIL Model Loading Parameter in FIL demo notebook#6562
rapids-bot[bot] merged 1 commit intorapidsai:branch-25.06from
csadorf:fix/docker-issue-749

Conversation

@csadorf
Copy link
Copy Markdown
Contributor

@csadorf csadorf commented Apr 21, 2025

Updates forest_inference_demo.ipynb to use path instead of filename parameter in ForestInference.load() calls to match the new FIL implementation.

Related Issues

@review-notebook-app
Copy link
Copy Markdown

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@github-actions github-actions Bot added the Cython / Python Cython or Python issue label Apr 21, 2025
@csadorf csadorf added bug Something isn't working non-breaking Non-breaking change labels Apr 21, 2025
@csadorf csadorf self-assigned this Apr 21, 2025
@csadorf csadorf requested a review from jameslamb April 21, 2025 19:18
@csadorf
Copy link
Copy Markdown
Contributor Author

csadorf commented Apr 21, 2025

/merge

@rapids-bot rapids-bot Bot merged commit e85aacf into rapidsai:branch-25.06 Apr 21, 2025
61 checks passed
@csadorf csadorf deleted the fix/docker-issue-749 branch April 21, 2025 20:56
Ofek-Haim pushed a commit to Ofek-Haim/cuml that referenced this pull request May 13, 2025
Updates `forest_inference_demo.ipynb` to use `path` instead of `filename` parameter in `ForestInference.load()` calls to match the new FIL implementation.

## Related Issues
- Fixes rapidsai/docker#749

Authors:
  - Simon Adorf (https://github.com/csadorf)

Approvers:
  - Jim Crist-Harif (https://github.com/jcrist)
  - James Lamb (https://github.com/jameslamb)

URL: rapidsai#6562
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working Cython / Python Cython or Python issue non-breaking Non-breaking change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] cuml/forest_inference_demo.ipynb notebook test failures

3 participants