Move cuml.accel tests out into own directory#6547
Merged
rapids-bot[bot] merged 1 commit intorapidsai:branch-25.06from Apr 16, 2025
Merged
Move cuml.accel tests out into own directory#6547rapids-bot[bot] merged 1 commit intorapidsai:branch-25.06from
cuml.accel tests out into own directory#6547rapids-bot[bot] merged 1 commit intorapidsai:branch-25.06from
Conversation
Previously tests for `cuml.accel` were found with the `cuml/tests/` directory. This was problematic because these tests only made sense to run with `cuml.accel` on, meaning some either the test runner had to explicitly ignore them or the tests needed to be marked to skip if `cuml.accel` wasn't enabled. Since we always run the accelerator tests in their own test run anyway, it makes more sense to extract these tests out into a separate tests directory. This is also what `cudf` did for their `cudf.pandas` tests, so there is already precedent here.
jcrist
added
improvement
jameslamb
approved these changes
Apr 15, 2025
divyegala
approved these changes
Apr 15, 2025
Member
Author
|
/merge |
Ofek-Haim
pushed a commit
to Ofek-Haim/cuml
that referenced
this pull request
May 13, 2025
Previously tests for `cuml.accel` were found with the `cuml/tests/` directory. This was problematic because these tests only made sense to run with `cuml.accel` on, meaning some either the test runner had to explicitly ignore them or the tests needed to be marked to skip if `cuml.accel` wasn't enabled. Since we always run the accelerator tests in their own test run anyway, it makes more sense to extract these tests out into a separate tests directory. This is also what `cudf` did for their `cudf.pandas` tests, so there is already precedent here. Authors: - Jim Crist-Harif (https://github.com/jcrist) Approvers: - James Lamb (https://github.com/jameslamb) - Divye Gala (https://github.com/divyegala) URL: rapidsai#6547
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously tests for
cuml.accelwere found with thecuml/tests/directory. This was problematic because these tests only made sense to run withcuml.accelon, meaning some either the test runner had to explicitly ignore them or the tests needed to be marked to skip ifcuml.accelwasn't enabled.Since we always run the accelerator tests in their own test run anyway, it makes more sense to extract these tests out into a separate tests directory. This is also what
cudfdid for theircudf.pandastests, so there is already precedent here.