Skip to content

Vendor RAPIDS.cmake#6531

Merged
rapids-bot[bot] merged 1 commit intorapidsai:branch-25.06from
bdice:vendor-RAPIDS.cmake
Apr 10, 2025
Merged

Vendor RAPIDS.cmake#6531
rapids-bot[bot] merged 1 commit intorapidsai:branch-25.06from
bdice:vendor-RAPIDS.cmake

Conversation

@bdice
Copy link
Copy Markdown
Contributor

@bdice bdice commented Apr 10, 2025

This works around a problem where GitHub is rejecting requests to the githubusercontent.com CDN. We vendor the contents of RAPIDS.cmake from rapidsai/rapids-cmake to avoid a network call.

xref: rapidsai/rapids-cmake#809
xref: https://github.com/rapidsai/build-infra/issues/206

@bdice bdice requested a review from a team as a code owner April 10, 2025 16:11
@bdice bdice requested review from KyleFromNVIDIA and teju85 April 10, 2025 16:11
@bdice bdice added non-breaking Non-breaking change improvement Improvement / enhancement to an existing function labels Apr 10, 2025
@github-actions github-actions Bot added Cython / Python Cython or Python issue CMake CUDA/C++ labels Apr 10, 2025
Copy link
Copy Markdown
Member

@pentschev pentschev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @bdice .

@bdice
Copy link
Copy Markdown
Contributor Author

bdice commented Apr 10, 2025

/merge

@rapids-bot rapids-bot Bot merged commit 9268c19 into rapidsai:branch-25.06 Apr 10, 2025
79 of 82 checks passed
Ofek-Haim pushed a commit to Ofek-Haim/cuml that referenced this pull request May 13, 2025
This works around a problem where GitHub is rejecting requests to the `githubusercontent.com` CDN. We vendor the contents of `RAPIDS.cmake` from `rapidsai/rapids-cmake` to avoid a network call.

xref: rapidsai/rapids-cmake#809
xref: rapidsai/build-infra#206

Authors:
  - Bradley Dice (https://github.com/bdice)

Approvers:
  - Peter Andreas Entschev (https://github.com/pentschev)
  - Kyle Edwards (https://github.com/KyleFromNVIDIA)

URL: rapidsai#6531
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CMake CUDA/C++ Cython / Python Cython or Python issue improvement Improvement / enhancement to an existing function non-breaking Non-breaking change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants