Unblock CI for 25.04#6519
Merged
raydouglass merged 2 commits intorapidsai:branch-25.04from Apr 8, 2025
Merged
Conversation
445cd53 to
2a8d33d
Compare
viclafargue
approved these changes
Apr 8, 2025
jakirkham
requested changes
Apr 8, 2025
Member
jakirkham
left a comment
There was a problem hiding this comment.
Thanks Simon! 🙏
Please update the Conda recipes as well
Contributor
Author
@jakirkham Xgboost is not a hard cuml dependency. It is currently not included in the conda build recipes. I am updating our test dependencies in the PR. |
This was referenced Apr 8, 2025
jakirkham
approved these changes
Apr 8, 2025
Member
jakirkham
left a comment
There was a problem hiding this comment.
Thanks for clarifying Simon! 🙏
Ok looks good
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses two issues that are currently blocking the cuML CI on the 25.04 release branch:
Out-of-memory (OOM) errors occurring in SVM tests on CUDA 11.8:
test_svc_methods, are failing with OOM errors and segmentation faultsXGBoost test dependency compatibility:
We expect to remove the constraint on the xgboost version once the issue is resolved in a future xgboost release.
We expect to be able to address the SVM test issue by reducing its memory footprint (see #6514), however here we are taking a more conservative approach to ensure that the CI pipeline is stable.
The remaining failing CI job is optional, the issue is going to be addressed on branch-25.06.