Remove dask to sparse workarounds#6489
Merged
rapids-bot[bot] merged 2 commits intorapidsai:branch-25.04from Mar 25, 2025
Merged
Remove dask to sparse workarounds#6489rapids-bot[bot] merged 2 commits intorapidsai:branch-25.04from
rapids-bot[bot] merged 2 commits intorapidsai:branch-25.04from
Conversation
This fixes a failure in `test_to_sparse_dask_array` with dask main. It seems that the workarounds previously implemented are fixed in cupy / dask and can now be removed from cuml. xref rapidsai/dask-upstream-testing#37
TomAugspurger
force-pushed
the
tom/fix/to_sparse_dask_array
branch
from
8bdfbe7 to
4a1e5f2
Compare
jcrist
approved these changes
Mar 25, 2025
Member
|
Thanks Tom! Looks like you have some flake8 errors, but otherwise LGTM. |
Contributor
Author
|
Thanks, the flake8 errors should be fixed now. https://github.com/rapidsai/cuml/actions/runs/14066201872/job/39390623623?pr=6489#step:9:1486 has a failure in |
Member
|
Yep, that's a known flaky test failure. See #6372. |
Member
|
/merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes a failure in
test_to_sparse_dask_arraywith dask main. It seems that the workarounds previously implemented are fixed in cupy / dask and can now be removed from cuml.xref rapidsai/dask-upstream-testing#37, specifically the failure here.
Not sure if anyone has the context to say for sure, but I'm curious how well we think the existing test suite would catch any regressions here. I haven't done any kind of performance / memory profiling to make sure there aren't any more subtle regressions.