Promote experimental FIL to stable#6464
Merged
rapids-bot[bot] merged 17 commits intorapidsai:branch-25.04from Mar 26, 2025
Merged
Promote experimental FIL to stable#6464rapids-bot[bot] merged 17 commits intorapidsai:branch-25.04from
rapids-bot[bot] merged 17 commits intorapidsai:branch-25.04from
Conversation
This reverts commit 06d5a62.
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
jcrist
reviewed
Mar 25, 2025
Member
jcrist
left a comment
jcrist
left a comment
There was a problem hiding this comment.
One small fixup, but otherwise this LGTM.
jcrist
approved these changes
Mar 26, 2025
csadorf
approved these changes
Mar 26, 2025
Contributor
|
/merge |
Contributor
dantegd
approved these changes
Mar 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR promotes experimental FIL to the new stable FIL. This is purely a Python-level change.
cuml.fil.fil.ForestInferencenow resolves to a thin wrapper aroundcuml.experimental.fil.fil.ForestInferencewith warnings about upcoming changes to the output shape of FIL predictions. Random forest estimators continue to use legacy FIL because of their usage ofTreeliteModel, an obsolete implementation detail of legacy FIL. A future change should switch this to Treelite's nativetreelite.Modelwrapper.The legacy FIL implementation has been moved to
cuml.legacy.fil.fil.ForestInference. This can be removed in 25.06. The thin wrapper aroundcuml.experimental.fil.fil.ForestInferencecan also be removed in 25.06 once users have a deprecation cycle to adapt to new output shapes.This is marked as a breaking change because it removes the
shape_strattribute fromForestInferenceobjects. This attribute is not used anywhere in cuML and appears to have existed primarily for debugging.Resolve #6460.