Skip to content

Clean up after removing KMeans deprecation warning #6445

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rapids-bot merged 3 commits into from
Mar 18, 2025
Merged

Clean up after removing KMeans deprecation warning #6445

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e527290
Clean up after removing KMeans deprecation
betatim Mar 17, 2025
8284587
Trigger CI
betatim Mar 18, 2025
6ff4c55
Merge branch 'branch-25.04' into remove-xfail-kmeans
jcrist Mar 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions python/cuml/cuml/tests/test_common.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,10 +19,6 @@
import cuml
from cuml.datasets import make_blobs

pytestmark = pytest.mark.filterwarnings(
"ignore:The default value of `n_init` will change from 1 to 'auto' in 25.04"
)


@pytest.mark.parametrize(
"Estimator",
Expand Down
3 changes: 0 additions & 3 deletions python/cuml/cuml/tests/test_public_methods_attributes.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,9 +26,6 @@
pytest.mark.filterwarnings(
"ignore:Starting from version 22.04, the default method of TSNE is 'fft'."
),
pytest.mark.filterwarnings(
"ignore:The default value of `n_init` will change from 1 to 'auto' in 25.04"
),
]


Expand Down
9 changes: 0 additions & 9 deletions python/cuml/cuml/tests/test_sklearn_import_export.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,12 +103,6 @@ def assert_estimator_roundtrip(
_ = original_params.pop("init", None)
_ = rm_params.pop("init", None)

# This failure will be fixed by
# https://github.com/rapidsai/cuml/pull/6142
# otherwise the predict with default n_init like this
# roundtrip will fail later.
pytest.xfail(reason="auto is not supported by cuML n_init yet")

def dict_diff(a, b):
# Get all keys from both dictionaries
all_keys = set(a.keys()) | set(b.keys())
Expand Down Expand Up @@ -158,9 +152,6 @@ def test_basic_roundtrip():
assert ckm.n_clusters == 13


@pytest.mark.filterwarnings(
"ignore:The default value of `n_init` will change from 1 to 'auto' in 25.04"
)
def test_kmeans(random_state):
# Using sklearn directly for demonstration
X, _ = make_blobs(
Expand Down