Remove debug logging from nearest neighbors test#6376
Merged
rapids-bot[bot] merged 1 commit intorapidsai:branch-25.04from Feb 27, 2025
Merged
Conversation
csadorf
added
bug
wphicks
approved these changes
Feb 26, 2025
Contributor
Author
|
/merge |
dantegd
added a commit
to dantegd/cuml
that referenced
this pull request
Feb 26, 2025
dantegd
approved these changes
Feb 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove extraneous debug logging from nearest neighbors test. This is likely the root cause for sporadic test failures we observe as part of our test pipeline since it changes the logger level globally. Specifically, I suspect it leads to failures in the doc-tests of other estimators since it causes extraneous verbose output.
To reproduce the issue, force the following execution order for both the offending and the affected tests:
pytest cuml/tests/test_nearest_neighbors.py cuml/tests/test_doctest.py -k 'test_nearest_neighbors_sparse or logistic'