UMAP fallback improvements#6358
Merged
rapids-bot[bot] merged 3 commits intorapidsai:branch-25.04from Feb 25, 2025
Merged
Conversation
jcrist
reviewed
Feb 24, 2025
Member
jcrist
left a comment
jcrist
left a comment
There was a problem hiding this comment.
If this is the most expedient way to get this working for the patch release, then that's fine. However:
- I don't love changing the
__init__validation if the accelerator is active or isn't. Ideally we'd handle this outside ofcuml.UMAPitself and in the proxy layer instead. This would be easier to do post refactor of course. - Ideally we shouldn't be doing validation like this in
__init__at all, following Scikit-Learn's convention (https://scikit-learn.org/stable/developers/develop.html#instantiation). Again, this is future looking, not something we need to handle now.
betatim
reviewed
Feb 24, 2025
dantegd
approved these changes
Feb 25, 2025
dantegd
added a commit
to dantegd/cuml
that referenced
this pull request
Feb 25, 2025
Member
|
/merge |
dantegd
added a commit
to dantegd/cuml
that referenced
this pull request
Feb 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.