Use new rapids-logger library#6289
Conversation
vyasr
added
improvement
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
github-actions
Bot
added
conda
|
/ok to test |
|
/ok to test |
|
/ok to test |
|
/ok to test |
|
/ok to test |
|
Didn't we change around logging stuff like a week or two ago? |
Yes we did! That was a transitional intermediate change to first get all of the RAPIDS repos onto a common logging framework so that we could start fixing problems in one place rather than in many. There was build-time code generation at that stage. This PR moves cuml to use the latest version of the common library, which reduces code generation in favor of an actual precompiled library (and similar PRs for other repos are open). |
jameslamb
left a comment
jameslamb
left a comment
There was a problem hiding this comment.
Just one small comment, otherwise looks good to me assuming the CI-specific testing stuff is removed.
|
Now unblocked. I re-triggered CI. |
|
/merge |
This was an oversight in #6289 Authors: - Vyas Ramasubramani (https://github.com/vyasr) Approvers: - Dante Gama Dessavre (https://github.com/dantegd) URL: #6511
This was an oversight in rapidsai#6289 Authors: - Vyas Ramasubramani (https://github.com/vyasr) Approvers: - Dante Gama Dessavre (https://github.com/dantegd) URL: rapidsai#6511
4 participants
Contributes to rapidsai/build-planning#104.