Support alpha=0 in Ridge#6236
Merged
rapids-bot[bot] merged 2 commits intorapidsai:branch-25.02from Jan 24, 2025
Merged
Conversation
When `alpha = 0`, `Ridge` is equivalent to a `LinearRegression`. Previously we checked if alpha was positive, scikit-learn instead requires that alpha is non-negative. This updates the check and adds a test.
jcrist
added
feature request
wphicks
approved these changes
Jan 21, 2025
Contributor
wphicks
left a comment
wphicks
left a comment
There was a problem hiding this comment.
Love this kind of change! More compatibility on edge cases makes me very happy. Let's merge!
Contributor
|
Currently blocked by |
Member
|
/merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When
alpha = 0,Ridgeis equivalent to aLinearRegression. Previously we checked if alpha was positive, scikit-learn instead requires that alpha is non-negative. This updates the check and adds a test.