Skip dispatching to GPU for unimplemented metrics in UMAP#6224
Merged
rapids-bot[bot] merged 9 commits intorapidsai:branch-25.02from Feb 6, 2025
Merged
Conversation
dantegd
reviewed
Jan 14, 2025
…ms/test_accel_umap.py Co-authored-by: Dante Gama Dessavre <[email protected]>
Member
Author
|
I feel like I am missing something. The tests are still failing with |
Member
Author
|
The answer is that the docs call it |
betatim
changed the title
betatim
force-pushed
the
blacklist-unsupported-metrics
branch
from
df524b9 to
18dc640
Compare
jameslamb
approved these changes
Jan 16, 2025
Member
jameslamb
left a comment
jameslamb
left a comment
There was a problem hiding this comment.
I recommend reverting that rapids-mamba-retry --quiet. I've explained the tradeoffs in a comment.
Marking this "approve" so you're not blocked waiting on ci-codeowners, and so you can merge it without further review if you all want to make a different choice than I would in the face of those tradeoffs.
This was referenced Jan 16, 2025
Closed
…ml into blacklist-unsupported-metrics
dantegd
approved these changes
Feb 6, 2025
Member
|
/merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This lists more metrics that the CPU umap library supports but cuml doesn't yet support. By listing them as not implemented we don't dispatch to the GPU when a user selects them.
Also added them to a test to check that they do not raise an error. It would be nice to check that they ran on the CPU when the accelerator is enabled, but I couldn't find a nice way to do it :-/ Ideas welcome.