Skip to content
Merged
Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
23 commits
Select commit Hold shift + click to select a range
3d0760e
FIX fix cloning
dantegd Jan 14, 2025
ca66732
Merge branch 'branch-25.02' into fix-interop-fixes
dantegd Feb 7, 2025
497d181
FIX changes from PR review to not use internal sklearn APIs and mate …
dantegd Feb 14, 2025
dce1539
Merge cuML branch-25.04
dantegd Feb 14, 2025
0d797aa
Merge branch 'branch-25.04' into fix-interop-fixes
dantegd Feb 14, 2025
0ef4895
ENH Keep list of original hyperparams that user passed
dantegd Feb 14, 2025
a00af9d
Merge branch 'fix-interop-fixes' of github.com:dantegd/cuml into fix-…
dantegd Feb 14, 2025
4e70f4c
FIX remove unused imported function
dantegd Feb 14, 2025
de3e234
Check that get_params and cloning work
betatim Feb 14, 2025
f14a14b
Typo fix
betatim Feb 20, 2025
5a02fd0
ENH multiple improvements by using the cpu_model as the reference tru…
dantegd Feb 21, 2025
e0cd0d5
FIX style fixes
dantegd Feb 21, 2025
d206bb8
Merge cuML branch-25.04
dantegd Feb 21, 2025
e70c3fb
Merge branch 'branch-25.04' into fix-interop-fixes
dantegd Feb 21, 2025
3785c4e
DOC correct docstrings
dantegd Feb 21, 2025
fd17f09
Merge branch 'fix-interop-fixes' of github.com:dantegd/cuml into fix-…
dantegd Feb 21, 2025
e7a35a1
Move imports to the top
betatim Feb 21, 2025
742404e
Fix style
betatim Feb 21, 2025
fa41369
FIX multiple fixes from issues raised in PR review
dantegd Feb 24, 2025
4fb4982
FIX skip pytest for cuml.accel output type when accel is not active
dantegd Feb 24, 2025
b2c31b2
FIX small test fixes
dantegd Feb 24, 2025
5a5bf59
Merge cuML branch-25.04
dantegd Feb 24, 2025
8eeb5b7
FIX fix from a bad merge
dantegd Feb 24, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions python/cuml/cuml/cluster/hdbscan/hdbscan.pyx
Original file line number Diff line number Diff line change
Expand Up @@ -771,7 +771,7 @@ class HDBSCAN(UniversalBase, ClusterMixin, CMajorInputTagMixin):
"""
Fit HDBSCAN model from features.
"""

self._all_finite = True
X_m, n_rows, n_cols, self.dtype = \
input_to_cuml_array(X, order='C',
check_dtype=[np.float32],
Expand Down Expand Up @@ -1163,7 +1163,7 @@ class HDBSCAN(UniversalBase, ClusterMixin, CMajorInputTagMixin):
def get_attr_names(self):
attr_names = ['labels_', 'probabilities_', 'cluster_persistence_',
'condensed_tree_', 'single_linkage_tree_',
'outlier_scores_']
'outlier_scores_', '_all_finite']
if self.gen_min_span_tree:
attr_names = attr_names + ['minimum_spanning_tree_']
if self.prediction_data:
Expand Down
4 changes: 4 additions & 0 deletions python/cuml/cuml/experimental/accel/estimator_proxy.py
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@
from cuml.internals import logger
from cuml.internals.global_settings import GlobalSettings
from cuml.internals.safe_imports import gpu_only_import, cpu_only_import
from sklearn.base import _clone_parametrized
from typing import Optional, Tuple, Dict, Any, Type, List


Expand Down Expand Up @@ -277,6 +278,9 @@ def __reduce__(self):
),
)

def __sklearn_clone__(self):
return _clone_parametrized(self)
Comment thread
betatim marked this conversation as resolved.
Outdated

logger.debug(
f"Created proxy estimator: ({module_b}, {original_class_name}, {ProxyEstimator})"
)
Expand Down