Update setulb call from Scipy for updated signature of 1.15#6207
Update setulb call from Scipy for updated signature of 1.15#6207rapids-bot[bot] merged 6 commits intorapidsai:branch-25.02from
Conversation
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
| wa[ib], | ||
| iwa[ib], | ||
| task[ib], | ||
| iprint, |
There was a problem hiding this comment.
Should we also remove this from the functions' signature if it has no more effect?
|
Looks reasonable. One thought I had: can we make it so that cuml works with both scipy < 1.15 and scipy >= 1.15? That would mean having some shim/compatibility built in at the point where we make use of the internal function. If we don't make it work with multiple versions, then we should bump the minimum version required in the dependencies. I have a slight preference for supporting several scipy versions instead of increasing the minimum version to 1.15 which is brand new. |
|
/ok to test |
|
This PR is blocking a handful of things now. It looks like the last CI run only failed due to intermittent failures, so I triggered a rerun to hopeful get us to passing. |
|
/merge |
5 participants
Resolves the immediate update identified in #6206, we still should update things to not use internals of Scipy.