Skip to content

Fix scikit-learn version specifier#6158

Merged
rapids-bot[bot] merged 2 commits intorapidsai:branch-24.12from
trxcllnt:fix/24.12-scikit-learn-version
Dec 4, 2024
Merged

Fix scikit-learn version specifier#6158
rapids-bot[bot] merged 2 commits intorapidsai:branch-24.12from
trxcllnt:fix/24.12-scikit-learn-version

Conversation

@trxcllnt
Copy link
Copy Markdown
Collaborator

@trxcllnt trxcllnt commented Dec 4, 2024

This version should be 1.5.*, otherwise this causes pip solves to fail with the following error when included with a wheel downloaded via pip download:

ERROR: Cannot install scikit-learn, scikit-learn 1.5.2 (from scikit_learn-1.5.2-cp312-cp312-manylinux_2_17_x86_64.manylinux2014_x86_64.whl) and scikit-learn==1.5 because these package versions have conflicting dependencies.

The conflict is caused by:
    The user requested scikit-learn 1.5.2 (from scikit_learn-1.5.2-cp312-cp312-manylinux_2_17_x86_64.manylinux2014_x86_64.whl)
    The user requested scikit-learn
    The user requested scikit-learn==1.5

To fix this you could try to:
1. loosen the range of package versions you've specified
2. remove package versions to allow pip to attempt to solve the dependency conflict

@trxcllnt trxcllnt requested a review from dantegd December 4, 2024 17:15
@trxcllnt trxcllnt requested a review from a team as a code owner December 4, 2024 17:15
@trxcllnt trxcllnt requested a review from bdice December 4, 2024 17:15
@dantegd dantegd added bug Something isn't working non-breaking Non-breaking change labels Dec 4, 2024
@dantegd
Copy link
Copy Markdown
Member

dantegd commented Dec 4, 2024

/merge

@github-actions github-actions Bot added conda conda issue Cython / Python Cython or Python issue labels Dec 4, 2024
@rapids-bot rapids-bot Bot merged commit 7e6dbc0 into rapidsai:branch-24.12 Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working conda conda issue Cython / Python Cython or Python issue non-breaking Non-breaking change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants