Skip to content

Adapt to rmm logger changes #6147

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
raydouglass merged 5 commits into from
Dec 2, 2024
Merged

Adapt to rmm logger changes #6147

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
f20c2a5
Adapt to rmm logger changes
vyasr Nov 17, 2024
6856431
Merge branch 'branch-25.02' into feat/rmm_logger
bdice Nov 27, 2024
aeef5cd
Update cpp/CMakeLists.txt
vyasr Nov 30, 2024
c0426e1
Make sure tests are linked to logger
vyasr Nov 30, 2024
244ae83
Make sure benchmarks are linked to the logger impl
vyasr Nov 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion cpp/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -626,9 +626,10 @@ if(BUILD_CUML_CPP_LIBRARY)
)

target_link_libraries(${CUML_CPP_TARGET}
PUBLIC rmm::rmm ${CUVS_LIB}
PUBLIC rmm::rmm rmm::rmm_logger ${CUVS_LIB}
${_cuml_cpp_public_libs}
PRIVATE ${_cuml_cpp_private_libs}
rmm::rmm_logger_impl
)

# If we export the libdmlc symbols, they can lead to weird crashes with other
Expand Down
1 change: 1 addition & 0 deletions cpp/bench/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,7 @@ if(BUILD_CUML_BENCH)
benchmark::benchmark
${TREELITE_LIBS}
raft::raft
rmm::rmm_logger_impl
)

target_include_directories(${CUML_CPP_BENCH_TARGET}
Expand Down
2 changes: 2 additions & 0 deletions cpp/test/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,8 @@ function(ConfigureTest)
CUDA::cusparse${_ctk_static_suffix}
$<$<BOOL:${LINK_CUFFT}>:CUDA::cufft${_ctk_static_suffix_cufft}>
rmm::rmm
rmm::rmm_logger
rmm::rmm_logger_impl
raft::raft
GTest::gtest
GTest::gtest_main
Expand Down